This page is no longer maintained — Please continue to the home page at www.scala-lang.org

Latest trunk broken?

4 replies

Thu, 2011-08-11, 18:25

gkossakowski

Joined: 2010-03-11,

Hi,
I tried to merge latest trunk into my fork (Scala+GWT) and I get crashes when I try to compile library with my own patches applied. You can see stacktrace here:
https://gist.github.com/1140228
Using `git bisect` I found that one of those changes is guilty:
https://github.com/paulp/scala-full/commit/f683c9703944569969712a032454f7cc70f6a3f1 https://github.com/paulp/scala-full/commit/7f21388c76ae1b16b37e2b446592a82312034c32
I cannot say if it's Paul's or Martin's because Martin's commit doesn't build (as Paul fixed). Before I go and spend more time on trying to nail it down I thought it would be good to ask if you are aware of problems with those changes and either plan to revert them or fix them.
--
Grzegorz Kossakowski

Thu, 2011-08-11, 18:37

#1

geoff

Joined: 2008-08-20,

Re: Latest trunk broken?

On Thu, Aug 11, 2011 at 07:24:49PM +0200, Grzegorz Kossakowski said
> Hi,
>
> I tried to merge latest trunk into my fork (Scala+GWT) and I get crashes
> when I try to compile library with my own patches applied. You can see
> stacktrace here:
>
> https://gist.github.com/1140228

I get the same exception when trying to compile the library for LLVM.
I'm not yet doing any patching with jdk2ikvm type stuff, so I don't
think that's to blame. If I remember correctly, the ant build doesn't
compile all of the library sources at once. Perhaps this problem would
show up if the entire library were compiled in one go for the java
target.

Thu, 2011-08-11, 20:27

#2

extempore

Joined: 2008-12-17,

Re: Latest trunk broken?

On 8/11/11 10:24 AM, Grzegorz Kossakowski wrote:
> https://github.com/paulp/scala-full/commit/f683c9703944569969712a032454f...
> https://github.com/paulp/scala-full/commit/7f21388c76ae1b16b37e2b446592a...

That's just one commit. The commit message in the second part of the
only commit, which based on your question maybe you haven't seen, is

Fixing the very broken build (was going for "compiling" mostly
because I can't be sure what to do with some of this) really this
code is certainly not correct, please review by odersky.

It's not every day I can work "this code is certainly not correct" into
a commit message.

Thu, 2011-08-11, 20:37

#3

extempore

Joined: 2008-12-17,

Re: Latest trunk broken?

On 8/11/11 12:26 PM, Paul Phillips wrote:
> It's not every day I can work "this code is certainly not correct" into
> a commit message.

And I'm so, so sorry I sent that before I remembered to add "usually
it's only implied."

Thu, 2011-08-11, 20:47

#4

gkossakowski

Joined: 2010-03-11,

Re: Latest trunk broken?

On 11 August 2011 21:26, Paul Phillips <paulp@improving.org> wrote:

On 8/11/11 10:24 AM, Grzegorz Kossakowski wrote:

https://github.com/paulp/scala-full/commit/f683c9703944569969712a032454f7cc70f6a3f1
https://github.com/paulp/scala-full/commit/7f21388c76ae1b16b37e2b446592a82312034c32

That's just one commit. The commit message in the second part of the only commit, which based on your question maybe you haven't seen, is

Fixing the very broken build (was going for "compiling" mostly
because I can't be sure what to do with some of this) really this
code is certainly not correct, please review by odersky.

It's not every day I can work "this code is certainly not correct" into a commit message.

Ok, I guess I'll wait until dust settles down in trunk.
Meanwhile, I'll cherry-pick fixes I need like SI-4891. Thanks for working on it!

--
Grzegorz Kossakowski

Copyright © 2012 École Polytechnique Fédérale de Lausanne (EPFL), Lausanne, Switzerland