Fix for SI-3501

I'm probably the wrong person to look at this, but just wanted to say I really am pumped that Google is submitting patches!
- Josh

On Thu, Aug 11, 2011 at 6:16 PM, Topher <topher@google.com> wrote:

Hi All,

I attached a patch for 3501 to the bug report.  Could I nag someone to
take a look?  I'd love to get some feedback, or to see it applied.

https://issues.scala-lang.org/browse/SI-3501

Thanks,
Topher.

On Thu, Aug 11, 2011 at 11:16 PM, Topher wrote:
> I attached a patch for 3501 to the bug report.  Could I nag someone to
> take a look?  I'd love to get some feedback, or to see it applied.
>
> https://issues.scala-lang.org/browse/SI-3501

Looks good to me ... patch applies cleanly to trunk, all scenarios in
the ticket (plus a couple more of my own) are resolved, and "ant test"
completes successfully.

Cheers,

Miles

The patch does look good. Thanks for submitting! I'll go ahead and apply it.
- Tiark

On Aug 21, 2011, at 7:59 PM, Miles Sabin wrote:

> On Thu, Aug 11, 2011 at 11:16 PM, Topher wrote:
>> I attached a patch for 3501 to the bug report. Could I nag someone to
>> take a look? I'd love to get some feedback, or to see it applied.
>>
>> https://issues.scala-lang.org/browse/SI-3501
>
> Looks good to me ... patch applies cleanly to trunk, all scenarios in
> the ticket (plus a couple more of my own) are resolved, and "ant test"
> completes successfully.
>
> Cheers,
>
>
> Miles
>

On Sun, Aug 21, 2011 at 9:07 PM, Tiark Rompf wrote:
> The patch does look good. Thanks for submitting! I'll go ahead and apply it.

Cool :-)

Given that this is a fix for a continuations plugin issue, rather than
a change in the core compiler or libraries, is there any chance we
could have this in 2.9.1 as well?

Cheers,

Miles

We *do* have to do another RC.   I'd love to try to include it.  I'll add it to the notes for the tuesday meeting.

On Sun, Aug 21, 2011 at 4:21 PM, Miles Sabin <miles@milessabin.com> wrote:

On Sun, Aug 21, 2011 at 9:07 PM, Tiark Rompf <tiark.rompf@epfl.ch> wrote:
> The patch does look good. Thanks for submitting! I'll go ahead and apply it.

Cool :-)

Given that this is a fix for a continuations plugin issue, rather than
a change in the core compiler or libraries, is there any chance we
could have this in 2.9.1 as well?

Cheers,


Miles

--
Miles Sabin
tel: +44 7813 944 528
gtalk: miles@milessabin.com
skype: milessabin
http://www.chuusai.com/
http://twitter.com/milessabin

On Mon, Aug 22, 2011 at 1:32 AM, Josh Suereth wrote:
> We *do* have to do another RC.   I'd love to try to include it.  I'll add it
> to the notes for the tuesday meeting.

It's probably too late for this, but I'll put it out there just in case:

'A conceivably pretty bad performance bug in builders.

SI-4821 pointed out that ArrayBuffer's ++ checks for a cheap size
method by matching on IndexedSeq, but mutable.IndexedSeq, so all
immutable collections are thrown in the same group as linear seqs.
I went looking for other examples of this and found them, in
key classes like Builder.

The "type shadowing trap" is a serious issue in the collections.'
Closes SI-4821, no review.
https://github.com/paulp/scala-full/commit/41e7bafb52c79793dd5a169256c2c...

Best,
Ismael