new collections

On Fri, 2009-05-08 at 18:44 +0200, martin odersky wrote:
> New collections have landed in trunk!

Great news. :) Do you feel like the major aspects of the new design are
more or less settled now?

Best,
Ismael

On Fri, May 8, 2009 at 6:51 PM, Ismael Juma wrote:
> On Fri, 2009-05-08 at 18:44 +0200, martin odersky wrote:
>> New collections have landed in trunk!
>
> Great news. :) Do you feel like the major aspects of the new design are
> more or less settled now?
>
I sure hope so. I don'tt have the stomach to do this another time!

Cheers

Great news indeed!
I think the whitepaper should be (in the form of) a SIP. Of course this SIP is automatically approved and that is acceptable if the author is the BAFL :)


On Fri, May 8, 2009 at 19:51, Ismael Juma <mlists@juma.me.uk> wrote:

On Fri, 2009-05-08 at 18:44 +0200, martin odersky wrote:
> New collections have landed in trunk!

Great news. :) Do you feel like the major aspects of the new design are
more or less settled now?

Best,
Ismael

--
 __~O
-\ <,       Christos KK Loverdos
(*)/ (*)      http://ckkloverdos.com

On Fri, May 08, 2009 at 06:44:37PM +0200, martin odersky wrote:
> New collections have landed in trunk! I just did a massive checkin.
> ant build test works, but I do not know how much else. I need your
> help to get all the other missing pieces working (again).

Since it is liable to bug me for the rest of my life perhaps we could
nip it in the bud: can we rename all the Traversible* classes to
Traversable* ? Or is that an alternate spelling in your neck of the
world? My dictionary doesn't contain it.

On Fri, May 8, 2009 at 5:44 PM, martin odersky wrote:
> New collections have landed in trunk! I just did a massive checkin.
> ant build test works, but I do not know how much else. I need your
> help to get all the other missing pieces working (again).

Excellent stuff :-)

Eclipse will be broken until I get rid of all the uses in it of Sean's
scala.collection.jcl._ stuff ... I'll do that ASAP.

Cheers,

Miles

Miles,

How are you replacing the old scala.collection.jcl?

I've written a small library* that I think is superior to the old jcl in some ways, but it will most likely need to be rewritten for 2.8 collections. I'll take a look at them tonight.

* http://github.com/jorgeortiz85/scala-javautils

--j

On Fri, May 8, 2009 at 12:20 PM, Miles Sabin <miles@milessabin.com> wrote:

On Fri, May 8, 2009 at 5:44 PM, martin odersky <martin.odersky@epfl.ch> wrote:
> New collections have landed in trunk! I just did a massive checkin.
> ant build test works, but I do not know how much else. I need your
> help to get all the other missing pieces working (again).

Excellent stuff :-)

Eclipse will be broken until I get rid of all the uses in it of Sean's
scala.collection.jcl._ stuff ... I'll do that ASAP.

Cheers,


Miles

--
Miles Sabin
tel: +44 (0)7813 944 528
skype:  milessabin
http://twitter.com/milessabin

On Fri, 2009-05-08 at 12:54 -0700, Jorge Ortiz wrote:
> Miles,
>
> How are you replacing the old scala.collection.jcl?

Not sure if that's everything, but some of it is already there:

https://lampsvn.epfl.ch/trac/scala/browser/scala/trunk/src/library/scala...

Ismael

On Fri, May 8, 2009 at 10:07 PM, Ismael Juma wrote:
> On Fri, 2009-05-08 at 12:54 -0700, Jorge Ortiz wrote:
>> Miles,
>>
>> How are you replacing the old scala.collection.jcl?
>
> Not sure if that's everything, but some of it is already there:
>
> https://lampsvn.epfl.ch/trac/scala/browser/scala/trunk/src/library/scala...
>
That's currently all that is planned as a replacement. If somebody
wants to update jcl, I''m happy to accept patches. But I won't do it
myself. Btw. both LinkedHashSet/Map and WeakHashSet/Map are now mart
of standard collections. from what I could see they were there main
things that people used in the jcl.

Cheers

On Fri, May 8, 2009 at 8:54 PM, Jorge Ortiz wrote:
> How are you replacing the old scala.collection.jcl?
>
> I've written a small library* that I think is superior to the old jcl in
> some ways, but it will most likely need to be rewritten for 2.8 collections.
> I'll take a look at them tonight.

My stuff is in scala.collection.JavaConversions. It's quite minimal
and just provides the basic Java <=> Scala conversions.

There's plenty of room for improvement, and I expect that there's lots
that could be borrowed from your library.

Cheers,

Miles

On Fri, May 8, 2009 at 8:20 PM, Miles Sabin wrote:
> On Fri, May 8, 2009 at 5:44 PM, martin odersky wrote:
>> New collections have landed in trunk! I just did a massive checkin.
>> ant build test works, but I do not know how much else. I need your
>> help to get all the other missing pieces working (again).
>
> Excellent stuff :-)
>
> Eclipse will be broken until I get rid of all the uses in it of Sean's
> scala.collection.jcl._ stuff ... I'll do that ASAP.

The Scala IDE should be fine now ...

A couple of things I noticed in the process,

* scala.collection.mutable still contains JavaSetAdapter and
JavaMapAdapter ... these were deprecated to Sean's old jcl stuff, so I
think they really should go away now.

* Sean used RichString explicitly in the plugin, I'm not entirely sure
why. He had been relying on an explict conversion back to String which
no longer appears to be available. Even if the right thing to do is
eliminate the explicit uses of RichString, was it really intentional
to remove the conversion?

Cheers,

Miles

Uh this is great news, I will look at the plugin stuff tomorrow
morning when I am in my office.

/Anders

Citat af martin odersky :

> New collections have landed in trunk! I just did a massive checkin.
> ant build test works, but I do not know how much else. I need your
> help to get all the other missing pieces working (again).
>
> Here's the current status:
>
> 1. A whitepaper on the new design is not yet written. That's my next task.
>
> 2. Some functionality (for instance scripting, and observables) is not
> yet present. I left the source files
> in the repository, but enclosed everything in
>
> /* TODO: Reintegrate
> ...
> */
>
> comments. Help in uncommenting these is much appreciated!
>
> 3. Some tests do not yet work. I moved non-working tests into a new
> directory scala/test/disabled. Help in making these work again is also
> appreciated! In particular there are two classes of tests that fail:
> (1) plugin tests, because they refer to a precompiled jar that refers
> to a file scala.Seq that does not exist anymore (it's not
> scala.collection.immutable.Sequence) (2) scalap tests that also refer
> to no longer existing classes. If Ilya and Anders could have a look at
> them that would be great! There are also some other random tests in
> disabled that need to be looked at.
>
> 4. Everybody check their code which is not in the scala repository
> against the new collections. If you notice problems, it's probably
> good to consult the forthcoming whitepaper to see how to fix them.
>
> Cheers
>