- About Scala
- Documentation
- Code Examples
- Software
- Scala Developers
Re: question about trac workflow
Mon, 2009-06-29, 23:06
When I submit patches, I usually put "patch" in the keywords section, but I can only do that when initially creating a ticket. So that doesn't work for patches for existing tickets...
I think a "patch available" or "patch submitted" state would be very useful.
On Mon, Jun 29, 2009 at 5:59 PM, Roland Kuhn <rk@rkuhn.info> wrote:
I think a "patch available" or "patch submitted" state would be very useful.
On Mon, Jun 29, 2009 at 5:59 PM, Roland Kuhn <rk@rkuhn.info> wrote:
Hi Erik,
okay, sounds sensible, so I've reopened it. To me, it seems that the state "patch available" is missing, otherwise, how do you find all tickets which are in principle resolved?
Ciao,
Roland
On 29 Jun 2009, at 23:46, Erik Engbrecht wrote:
I think the last step should be done by someone with commit rights after committing the patch, because it's not really fixed until it is committed.
On Mon, Jun 29, 2009 at 5:45 PM, Roland Kuhn <rk@rkuhn.info> wrote:
Hi,
I've just uploaded a patch for https://lampsvn.epfl.ch/trac/scala/ticket/2074 and set that ticket to fixed, which made it 'closed'. Is that correct or should that last step be done by someone with SVN commit rights?
Ciao,
Roland
Or I prepend [PATCH] to subject of the ticket, makes it easier for committers to
see there's something that may be easily committed.
Regards,
Blair
Erik Engbrecht wrote:
> When I submit patches, I usually put "patch" in the keywords section,
> but I can only do that when initially creating a ticket. So that
> doesn't work for patches for existing tickets...
>
> I think a "patch available" or "patch submitted" state would be very useful.
>
> On Mon, Jun 29, 2009 at 5:59 PM, Roland Kuhn > wrote:
>
> Hi Erik,
>
> okay, sounds sensible, so I've reopened it. To me, it seems that the
> state "patch available" is missing, otherwise, how do you find all
> tickets which are in principle resolved?
>
> Ciao,
>
> Roland
>
>
> On 29 Jun 2009, at 23:46, Erik Engbrecht wrote:
>
> I think the last step should be done by someone with commit
> rights after committing the patch, because it's not really fixed
> until it is committed.
>
> On Mon, Jun 29, 2009 at 5:45 PM, Roland Kuhn > wrote:
> Hi,
>
> I've just uploaded a patch for
> https://lampsvn.epfl.ch/trac/scala/ticket/2074 and set that
> ticket to fixed, which made it 'closed'. Is that correct or
> should that last step be done by someone with SVN commit rights?
>
> Ciao,
>
> Roland
>
>
>
> --
> http://erikengbrecht.blogspot.com/
>
>
>
>
>