Re: [scala-bts] #2354: XML Parser fails if CDATA ends with a square bracket

-----------------------------+----------------------------------------------
Reporter: robennals | Owner: scala-xml_team
Type: defect | Status: reopened
Priority: normal | Component: XML support
Version: Unreleased-2.8.x | Resolution:
Keywords: |
-----------------------------+----------------------------------------------
Changes (by robennals):

* status: closed => reopened
* resolution: fixed =>

Comment:

I just tested this again on a recent nightly build of 2.8 and it seems to
still be broken.

-----------------------------+----------------------------------------------
Reporter: robennals | Owner: scala-xml_team
Type: defect | Status: closed
Priority: normal | Component: XML support
Version: Unreleased-2.8.x | Resolution: fixed
Keywords: |
-----------------------------+----------------------------------------------
Changes (by extempore):

* status: reopened => closed
* resolution: => fixed

Comment:

It works fine for me. Please don't reopen unless you can tell me very
precisely how to reproduce.

-----------------------------+----------------------------------------------
Reporter: robennals | Owner: scala-xml_team
Type: defect | Status: reopened
Priority: normal | Component: XML support
Version: Unreleased-2.8.x | Resolution:
Keywords: |
-----------------------------+----------------------------------------------
Changes (by robennals):

* status: closed => reopened
* resolution: fixed =>

Comment:

Sorry for not including a test case. I thought that the test case I gave
earlier still failed.

Here is a simple test case that definitely fails on the latest nightly
build:

import scala.xml.parsing._
import scala.io.Source

val xml_good = ""
val xml_bad = ""

val parser_good =
ConstructingParser.fromSource(Source.fromString(xml_good),false)
parser_good.document

val parser_bad =
ConstructingParser.fromSource(Source.fromString(xml_bad),false)
parser_bad.document

BOOOM!!!!

-----------------------------+----------------------------------------------
Reporter: robennals | Owner: scala-xml_team
Type: defect | Status: reopened
Priority: normal | Component: XML support
Version: Unreleased-2.8.x | Resolution:
Keywords: |
-----------------------------+----------------------------------------------

Comment(by robennals):

Somehow lost a linebreak in the copy/paste there.
That should be:

val xml_good = ""
val xml_bad = ""

val parser_good =
ConstructingParser?.fromSource(Source.fromString(xml_good),false)
parser_good.document

val parser_bad =
ConstructingParser?.fromSource(Source.fromString(xml_bad),false)
parser_bad.document

BOOOM!!!!

parse_good works fine, but parser_bad fails.

This is running scala-2.8.0.r20145-b20091216020133 downloaded from the
Scala website a couple of minutes ago.

-Rob

-----------------------------+----------------------------------------------
Reporter: robennals | Owner: scala-xml_team
Type: defect | Status: reopened
Priority: normal | Component: XML support
Version: Unreleased-2.8.x | Resolution:
Keywords: |
-----------------------------+----------------------------------------------

Comment(by robennals):

Your link didn't work and so does the 'help' link at the top. Where should
I read how to do markup?

Does this comment imply that there is an alternative XML parser available
that works reliably?

-----------------------------+----------------------------------------------
Reporter: robennals | Owner: scala-xml_team
Type: defect | Status: reopened
Priority: normal | Component: XML support
Version: Unreleased-2.8.x | Resolution:
Keywords: |
-----------------------------+----------------------------------------------

Comment(by extempore):

Please read how to do markup. Use triple curly braces to bookend code.

Here is my comment in MarkupParsers which may serve to explain how this
bug still exists after I already fixed it. I guess cutting and pasting
huge swaths of code might cause a maintenance issue. Alert the media.

{{{
// XXX/Note: many/most of the functions in here are almost direct cut and
pastes
// from another file - scala.xml.parsing.MarkupParser, it looks like.
// (It was like that when I got here.) They used to be commented
"[Duplicate]" but
// since approximately all of them were, I snipped it as noise. As far as
I can
// tell this wasn't for any particularly good reason, but slightly
different
// compiler and library parser interfaces meant it would take some setup.
//
// I rewrote most of these, but not as yet the library versions: so if you
are
// tempted to touch any of these, please be aware of that situation and
try not
// to let it get any worse. -- paulp
}}}

-----------------------------+----------------------------------------------
Reporter: robennals | Owner: scala-xml_team
Type: defect | Status: reopened
Priority: normal | Component: XML support
Version: Unreleased-2.8.x | Resolution:
Keywords: |
-----------------------------+----------------------------------------------

Comment(by extempore):

Replying to [comment:7 robennals]:
> Your link didn't work and so does the 'help' link at the top. Where
should I read how to do markup?

Wow, that help link was spectacularly unhelpful. I helped it out, should
be more edifying now.

> Does this comment imply that there is an alternative XML parser
available that works reliably?

No, the comment was saying that there is a bunch of duplicated XML parsing
code between the compiler and the library, and thanks to Cutty
McPastington it's easy to fix a bug in one and leave it in the other.

-----------------------------+----------------------------------------------
Reporter: robennals | Owner: scala-xml_team
Type: defect | Status: closed
Priority: normal | Component: XML support
Version: Unreleased-2.8.x | Resolution: fixed
Keywords: |
-----------------------------+----------------------------------------------
Changes (by extempore):

* status: reopened => closed
* resolution: => fixed

Comment:

Fixed (for the second and final time) in r20519.

-----------------------------+----------------------------------------------
Reporter: robennals | Owner: scala-xml_team
Type: defect | Status: closed
Priority: normal | Component: XML support
Version: Unreleased-2.8.x | Resolution: fixed
Keywords: |
-----------------------------+----------------------------------------------

Comment(by extempore):

(In [20582]) More work consolidating the XML code needlessly duplicated
between the compiler and the library. Having to fix #2354
in two completely different places was I found very motivating.