Re: [scala-bts] #2364: Fix for FactoryAdapter: scopeStack initialization

-----------------------------+----------------------------------------------
Reporter: wrburdick | Owner: scala-xml_team
Type: defect | Status: closed
Priority: normal | Component: Compiler
Version: Unreleased-2.8.x | Resolution: fixed
Keywords: |
-----------------------------+----------------------------------------------
Changes (by extempore):

* cc: paulp@… (added)
* status: new => closed
* version: => Unreleased-2.8.x
* resolution: => fixed

Comment:

Actually I don't think that is the correct correction. I believe I fixed
it in r18749, but please let me know if you find otherwise.

-----------------------------+----------------------------------------------
Reporter: wrburdick | Owner: scala-xml_team
Type: defect | Status: reopened
Priority: normal | Component: Compiler
Version: Unreleased-2.8.x | Resolution:
Keywords: |
-----------------------------+----------------------------------------------
Changes (by wrburdick):

* status: closed => reopened
* resolution: fixed =>

Comment:

Regression?

I had to put in my (wrong?) fix again to get things working in my code. I
attached some test code.

Bill

-----------------------------+----------------------------------------------
Reporter: wrburdick | Owner: scala-xml_team
Type: defect | Status: reopened
Priority: normal | Component: Standard Library
Version: Unreleased-2.8.x | Resolution:
Keywords: |
-----------------------------+----------------------------------------------
Changes (by wrburdick):

* component: Compiler => Standard Library

-----------------------------+----------------------------------------------
Reporter: wrburdick | Owner: scala-xml_team
Type: defect | Status: reopened
Priority: normal | Component: Standard Library
Version: Unreleased-2.8.x | Resolution:
Keywords: |
-----------------------------+----------------------------------------------

Comment(by wrburdick):

adding this line to !NoBindingFactoryAdapter's constructor makes the
problem go away (as in my attachment):
{{{
scopeStack push TopScope
}}}
I put it there since I only use !NoBindingFactoryAdapter, I put the fix
there instead of in !FactoryAdapter, where it was.

-----------------------------+----------------------------------------------
Reporter: wrburdick | Owner: scala-xml_team
Type: defect | Status: reopened
Priority: normal | Component: Standard Library
Version: Unreleased-2.8.x | Resolution:
Keywords: |
-----------------------------+----------------------------------------------

Comment(by extempore):

Noting regression was introduced in r19949 to fix #2721.

-----------------------------+----------------------------------------------
Reporter: wrburdick | Owner: scala-xml_team
Type: defect | Status: closed
Priority: normal | Component: Standard Library
Version: Unreleased-2.8.x | Resolution: fixed
Keywords: |
-----------------------------+----------------------------------------------
Changes (by extempore):

* status: reopened => closed
* resolution: => fixed

Comment:

Fix and test case in r20453.