[netbeans] RangePositions$ValidateError on fool code fragment

On Sat, Nov 14, 2009 at 12:55 PM, Andrew Gaydenko wrote:
> Accidentally, during editing, there was such fragment in editor (yes,
> it's strange fragment):
>
>  def this.
>
> After hitting '.' the error shown below rises. I have tried to
> reproduce - it was reproduced always, without exceptions :-)

Open a ticket for it in Trac and I'll take a look at it. Thanks ...

Cheers,

Miles

On Saturday 14 November 2009 16:12:36 Miles Sabin wrote:
> On Sat, Nov 14, 2009 at 12:55 PM, Andrew Gaydenko wrote:
> > Accidentally, during editing, there was such fragment in editor (yes,
> > it's strange fragment):
> >
> > def this.
> >
> > After hitting '.' the error shown below rises. I have tried to
> > reproduce - it was reproduced always, without exceptions :-)
>
> Open a ticket for it in Trac and I'll take a look at it. Thanks ...
>
> Cheers,
>
>
> Miles

Miles,

scala.collection.* and org.netbeans.modules.* are in stack only.
Is it really for you? :-)

Andrew

On Sat, Nov 14, 2009 at 1:37 PM, Andrew Gaydenko wrote:
> scala.collection.* and org.netbeans.modules.* are in stack only.
> Is it really for you? :-)

Hmm ...

Well, as a general rule anything related to validation errors on
positions would be down to scalac.

However it looks as though Cayouan has forked part of scalac relating
to it's interactive mode. That's a big shame ... I would have expected
to see a patch coming back to EPFL rather than that. Really very
disappointing.

In any case, that bug is most likely reproducible with the real
scalac, so a Trac ticket with the test case would still be welcome.

Cheers,

Miles

On Saturday 14 November 2009 16:58:42 Miles Sabin wrote:
> On Sat, Nov 14, 2009 at 1:37 PM, Andrew Gaydenko wrote:
> > scala.collection.* and org.netbeans.modules.* are in stack only.
> > Is it really for you? :-)
>
> Hmm ...
>
> Well, as a general rule anything related to validation errors on
> positions would be down to scalac.
>
> However it looks as though Cayouan has forked part of scalac relating
> to it's interactive mode. That's a big shame ... I would have expected
> to see a patch coming back to EPFL rather than that. Really very
> disappointing.
>
> In any case, that bug is most likely reproducible with the real
> scalac, so a Trac ticket with the test case would still be welcome.
>
> Cheers,
>
>
> Miles

It isn't scalac error - at least I have not idea how to reproduce it with
"scalac File.scala". Compiling something stupid like

object Dot {
def this.
}

just report an error. As I have wrote, the error arises after hitting dot
character - probably CC-related events chain is activated,

(I have not appropriate English feeling, so just hope "shame" is rather soft
word :-))

Andrew

On Sat, Nov 14, 2009 at 9:58 PM, Miles Sabin wrote:
> On Sat, Nov 14, 2009 at 1:37 PM, Andrew Gaydenko wrote:
>> scala.collection.* and org.netbeans.modules.* are in stack only.
>> Is it really for you? :-)

Andrew, go to create a ticket for it on lamp's trac, it will be common
issue from scalac as Miles said.

>
> Hmm ...
>
> Well, as a general rule anything related to validation errors on
> positions would be down to scalac.
>
> However it looks as though Cayouan has forked part of scalac relating
> to it's interactive mode. That's a big shame ... I would have expected
> to see a patch coming back to EPFL rather than that. Really very
> disappointing.

I've fed back some patches back to EPFL when I though these patches
looked reasonable and with good quality. I forked interactive mode
code and keeps syncing with EPFL code, so I can fed back quality
patches back when I though it's good enough later, and, I just cannot
wait for all my ugly quick fixing code should/could be accepted by
EPFL, but I just keep fast going as I can.

BTW, I'm preparing another patch to fix
https://lampsvn.epfl.ch/trac/scala/ticket/2627.

Cheers,
Caoyuan

>
> In any case, that bug is most likely reproducible with the real
> scalac, so a Trac ticket with the test case would still be welcome.
>
> Cheers,
>
>
> Miles
>
> --
> Miles Sabin
> tel: +44 (0)7813 944 528
> skype:  milessabin
> http://www.chuusai.com/
> http://twitter.com/milessabin
>

On Saturday 14 November 2009 17:14:17 Caoyuan wrote:
> On Sat, Nov 14, 2009 at 9:58 PM, Miles Sabin wrote:
> > On Sat, Nov 14, 2009 at 1:37 PM, Andrew Gaydenko wrote:
> >> scala.collection.* and org.netbeans.modules.* are in stack only.
> >> Is it really for you? :-)
>
> Andrew, go to create a ticket for it on lamp's trac, it will be common
> issue from scalac as Miles said.

Ok, you both have won me :-) - have opened:

https://lampsvn.epfl.ch/trac/scala/ticket/2633

Andrew

On Sat, Nov 14, 2009 at 10:09 PM, Andrew Gaydenko wrote:
> On Saturday 14 November 2009 16:58:42 Miles Sabin wrote:
>> On Sat, Nov 14, 2009 at 1:37 PM, Andrew Gaydenko wrote:
>> > scala.collection.* and org.netbeans.modules.* are in stack only.
>> > Is it really for you? :-)
>>
>> Hmm ...
>>
>> Well, as a general rule anything related to validation errors on
>> positions would be down to scalac.
>>
>> However it looks as though Cayouan has forked part of scalac relating
>> to it's interactive mode. That's a big shame ... I would have expected
>> to see a patch coming back to EPFL rather than that. Really very
>> disappointing.
>>
>> In any case, that bug is most likely reproducible with the real
>> scalac, so a Trac ticket with the test case would still be welcome.
>>
>> Cheers,
>>
>>
>> Miles
>
> It isn't scalac error - at least I have not idea how to reproduce it with
> "scalac File.scala". Compiling something stupid like
>
> object Dot {
>  def this.
> }
>
> just report an error. As I have wrote, the error arises after hitting dot
> character - probably CC-related events chain is activated,

It's a bug relative to
scala.tools.nsc.interactive.RangePositions.scala, just file a ticket
with the stack trace.

>
> (I have not appropriate English feeling, so just hope "shame" is rather soft
> word :-))

That's OK, I know what I've done of reporting bugs and submitting
patched to EPFL. I'm actually going to look to be a contributor of
some parts of EPFL's scalac code, I just don't know how can I be
qualified, and I'm, doing these works in my spare time.

>
>
> Andrew
>

On Sat, Nov 14, 2009 at 2:21 PM, Caoyuan wrote:
> On Sat, Nov 14, 2009 at 10:09 PM, Andrew Gaydenko wrote:
>> (I have not appropriate English feeling, so just hope "shame" is rather soft
>> word :-))

Replying to Andrew:

Actually, it was intended to be a bit harsh.

I and Martin and Iulian and now Hubert at EPFL have put a huge amount
of work over the last six months or so ripping this stuff out of the
old Eclipse plugin (where it was unmaintainable and inaccessible to
pretty much everyone) and moving it into scalac where it can be used
by and built on by the whole Scala community.

That being so, it's really very disappointing to discover that it's
being used, and bugs found and fixed in it but that those fixes
haven't been fed back. Of course the license allows this, but it
leaves a pretty sour taste ...

I hope this will change soon.

> That's OK, I know what I've done of reporting bugs and submitting
> patched to EPFL. I'm actually going to look to be a contributor of
> some parts of EPFL's scalac code, I just don't know how can I be
> qualified, and I'm, doing these works in my spare time.

Replying to Caoyuan:

Did you try mailing Martin and asking? I'd be very surprised if the
answer was no.

In any case, a patch attached to a Trac ticket will always get my attention.

Cheers,

Miles

On Sat, 2009-11-14 at 14:49 +0000, Miles Sabin wrote:
> Actually, it was intended to be a bit harsh.
>
> I and Martin and Iulian and now Hubert at EPFL have put a huge amount
> of work over the last six months or so ripping this stuff out of the
> old Eclipse plugin (where it was unmaintainable and inaccessible to
> pretty much everyone) and moving it into scalac where it can be used
> by and built on by the whole Scala community.

Thanks for that. I believe that will work out to be a good investment.

> That being so, it's really very disappointing to discover that it's
> being used, and bugs found and fixed in it but that those fixes
> haven't been fed back. Of course the license allows this, but it
> leaves a pretty sour taste ...
>
> I hope this will change soon.

You make it sound like Caoyuan has been doing his own thing without
communicating, but he has been active in Trac:

https://lampsvn.epfl.ch/trac/scala/query?status=assigned&status=closed&s...

I think that's good considering that this is just a part-time thing for
Caoyuan.

Best,
Ismael

On Sat, Nov 14, 2009 at 3:29 PM, Ismael Juma wrote:
> On Sat, 2009-11-14 at 14:49 +0000, Miles Sabin wrote:
>> I and Martin and Iulian and now Hubert at EPFL have put a huge amount
>> of work over the last six months or so ripping this stuff out of the
>> old Eclipse plugin (where it was unmaintainable and inaccessible to
>> pretty much everyone) and moving it into scalac where it can be used
>> by and built on by the whole Scala community.
>
> Thanks for that. I believe that will work out to be a good investment.

That's dependent on the traffic not being one-way.

>> That being so, it's really very disappointing to discover that it's
>> being used, and bugs found and fixed in it but that those fixes
>> haven't been fed back. Of course the license allows this, but it
>> leaves a pretty sour taste ...
>>
>> I hope this will change soon.
>
> You make it sound like Caoyuan has been doing his own thing without
> communicating, but he has been active in Trac:
>
> https://lampsvn.epfl.ch/trac/scala/query?status=assigned&status=closed&s...
>
> I think that's good considering that this is just a part-time thing for
> Caoyuan.

Very few of those tickets relate to scala.tools.nsc.interactive or the
other IDE-related functionality: if there's enough of a delta in
org.netbeans.modules.scala.core.interactive to warrant a fork then I
would have expected to see a lot more ... along with a whacking great
patch.

But whatever ... if the tickets and patches surface that'll be good
for everyone.

Cheers,

Miles

On Sat, Nov 14, 2009 at 10:49 PM, Miles Sabin wrote:
> On Sat, Nov 14, 2009 at 2:21 PM, Caoyuan wrote:
>> On Sat, Nov 14, 2009 at 10:09 PM, Andrew Gaydenko wrote:
>>> (I have not appropriate English feeling, so just hope "shame" is rather soft
>>> word :-))
>
> Replying to Andrew:
>
> Actually, it was intended to be a bit harsh.
>
> I and Martin and Iulian and now Hubert at EPFL have put a huge amount
> of work over the last six months or so ripping this stuff out of the
> old Eclipse plugin (where it was unmaintainable and inaccessible to
> pretty much everyone) and moving it into scalac where it can be used
> by and built on by the whole Scala community.
>
> That being so, it's really very disappointing to discover that it's
> being used, and bugs found and fixed in it but that those fixes
> haven't been fed back. Of course the license allows this, but it
> leaves a pretty sour taste ...

I do not submit patches to projects that are not managed by myself
until I think I've got the causes and the rational logic behind of
them, that's also another respect for others works in my eyes. (I
don't think anyone will be liking to read a lot of nonsense code).
That's why I did not submit some of them to EPEL. But, all of my works
are truly opened and can be available via a simple browser checking or
hg clone, just as I checkout/browse the newest Scala trunk code to
keep sync with them every night, including yours. I am with best
respect for Martin, and Iulian and Hubert and your work.

Sometime, it's difficult to narrow down the causes of bugs, so it's
just a quick fix, if I have enough time to evaluate the patches, I'll
submit it, but before I believe it's a good one, I'll stay there.
Unfortunately, except my daily work, I also maintains at least 3
open-source project, they have consumed almost all of my spare time,
so, that's it.

> I hope this will change soon.
>
>> That's OK, I know what I've done of reporting bugs and submitting
>> patched to EPFL. I'm actually going to look to be a contributor of
>> some parts of EPFL's scalac code, I just don't know how can I be
>> qualified, and I'm, doing these works in my spare time.
>
> Replying to Caoyuan:
>
> Did you try mailing Martin and asking? I'd be very surprised if the
> answer was no.
>
> In any case, a patch attached to a Trac ticket will always get my attention.
>
> Cheers,
>
>
> Miles
>
> --
> Miles Sabin
> tel: +44 (0)7813 944 528
> skype:  milessabin
> http://www.chuusai.com/
> http://twitter.com/milessabin
>

On Sat, Nov 14, 2009 at 3:59 PM, Caoyuan wrote:
> Sometime, it's difficult to narrow down the causes of bugs, so it's
> just a quick fix, if I have enough time to evaluate the patches, I'll
> submit it, but before I believe it's a good one, I'll stay there.
> Unfortunately, except my daily work, I also maintains at least 3
> open-source project, they have consumed almost all of my spare time,
> so, that's it.

OK, that's fair enough. But if you hit issues you could at least mail
me and give me a heads up because, as you know, bugs in common code
which affect Netbeans are likely to affect Eclipse as well.

Otherwise from where I'm sitting it almost looks like you're only
opening tickets for stuff you can't fix yourself, letting me (poor
schmuck that I am) fix them for you, and keeping your own fixes to
yourself.

Nb. "looks like" and "from where I'm sitting" ... hopefully it is just
appearances and we'll see more coming back in the near future :-)

Cheers,

Miles

On Sun, Nov 15, 2009 at 12:14 AM, Miles Sabin wrote:
> On Sat, Nov 14, 2009 at 3:59 PM, Caoyuan wrote:
>> Sometime, it's difficult to narrow down the causes of bugs, so it's
>> just a quick fix, if I have enough time to evaluate the patches, I'll
>> submit it, but before I believe it's a good one, I'll stay there.
>> Unfortunately, except my daily work, I also maintains at least 3
>> open-source project, they have consumed almost all of my spare time,
>> so, that's it.
>
> OK, that's fair enough. But if you hit issues you could at least mail
> me and give me a heads up because, as you know, bugs in common code
> which affect Netbeans are likely to affect Eclipse as well.
>
> Otherwise from where I'm sitting it almost looks like you're only
> opening tickets for stuff you can't fix yourself, letting me (poor
> schmuck that I am) fix them for you, and keeping your own fixes to
> yourself.

No. The most parts of code I did not submit is in
interative.Global.scala, and some of them I patched only works under
my design (I also patched nsc.Global for to co-work with these code).
there are also some legal code I have not cleaned up yet. Maybe the
patches of typeMembers/scopeMembers are also works under Eclipse, but
I don't like these code, since I'm not sure about it :-)

And, where is the point of "you're only opening tickets for stuff you
can't fix yourself" from? I of course can quick fix them by myself,
but I'm not sure if it will break others work. BTW, most opening
tickets are related to scala.library, and some of them were marked as
invalid :-)

ok, truly enough now. You'd better to monitor my daily work if you'd like to:
http://hg.netbeans.org/main/contrib

Cheers,
-Caoyuan

>
> Nb. "looks like" and "from where I'm sitting" ... hopefully it is just
> appearances and we'll see more coming back in the near future :-)
>
> Cheers,
>
>
> Miles
>
> --
> Miles Sabin
> tel: +44 (0)7813 944 528
> skype:  milessabin
> http://www.chuusai.com/
> http://twitter.com/milessabin
>

On Sat, Nov 14, 2009 at 4:40 PM, Caoyuan wrote:
> ok, truly enough now. You'd better to monitor my daily work if you'd like to:
> http://hg.netbeans.org/main/contrib

Thanks a bunch ...

Cheers,

Miles

On Sat, Nov 14, 2009 at 2:23 PM, Andrew Gaydenko wrote:
> On Saturday 14 November 2009 17:14:17 Caoyuan wrote:
>> On Sat, Nov 14, 2009 at 9:58 PM, Miles Sabin wrote:
>> > On Sat, Nov 14, 2009 at 1:37 PM, Andrew Gaydenko wrote:
>> >> scala.collection.* and org.netbeans.modules.* are in stack only.
>> >> Is it really for you? :-)
>>
>> Andrew, go to create a ticket for it on lamp's trac, it will be common
>> issue from scalac as Miles said.
>
> Ok, you both have won me :-) - have opened:
>
> https://lampsvn.epfl.ch/trac/scala/ticket/2633

OK, it looks like this was fixed on trunk by,

https://lampsvn.epfl.ch/trac/scala/changeset/19144

see also my comment on #2633.

Does this correspond to the version of scalac you have?

Cheers,

Miles

On Saturday 14 November 2009 23:14:36 you wrote:
> > Ok, you both have won me :-) - have opened:
> >
> > https://lampsvn.epfl.ch/trac/scala/ticket/2633
>
> OK, it looks like this was fixed on trunk by,
>
> https://lampsvn.epfl.ch/trac/scala/changeset/19144
>
> see also my comment on #2633.
>
> Does this correspond to the version of scalac you have?

r19647 is in use at the moment.

Andrew