killing models for fun

On Fri, Mar 5, 2010 at 7:52 PM, Paul Phillips wrote:
> Does anyone use these files for anything? Can they perhaps be removed or
> at least moved out of trunk? Nothing else in trunk even notices if
> they're snipped.  If there's something which merits salvaging let me
> know what it is and I'm happy to salvage it on the way to the landfill.
>
> src/compiler/scala/tools/nsc/models/Models.scala
> src/compiler/scala/tools/nsc/models/SemanticTokens.scala
> src/compiler/scala/tools/nsc/models/Signatures.scala
> src/compiler/scala/tools/nsc/symtab/SymbolWalker.scala

At some point in the dim distant past (some of) these were used by the
IDE. That's not been the case for quite some time, however, so no
objections from me if you want to cull them.

Cheers,

Miles

Old ScalaDoc might have used them and maybe vscaladoc as well since it
relies on the same model. David Bernard and Gilles should be able to
answer that.
If ScalaDoc used to use them I would leave them in for the moment, as
the ScalaDoc situation is still in flux, and we might see a new
incarnation of vscaladoc (I hope so!)

Cheers

Hello.

> Old ScalaDoc might have used them and maybe vscaladoc as well since it
> relies on the same model. David Bernard and Gilles should be able to
> answer that.
> If ScalaDoc used to use them I would leave them in for the moment, as
> the ScalaDoc situation is still in flux, and we might see a new
> incarnation of vscaladoc (I hope so!)

I don't think that any of the classes below are used by vscaladoc: I just checked its sources and couldn't find any reference to any of them. I can't recall whether the old Scaladoc used to use them, but I doubt it as vscaladoc's model extraction part is basically a copy of that of the old Scaladoc.

Concerning the new incarnation of vscaladoc, David Bernard had told me that he eventually wanted to develop it around the Scaladoc 2 model found in nsc.doc.model. I am not sure, however, if he plans to release an intermediary version based on his current codebase.

In any case, as far as Scaladoc is concerned, these classes can go. They probably never had anything to do with Scaladoc but, as Miles pointed out, were part of the Eclipse plugin.

Cheers,
Gilles.

>> Does anyone use these files for anything? Can they perhaps be removed or
>> at least moved out of trunk? Nothing else in trunk even notices if
>> they're snipped. If there's something which merits salvaging let me
>> know what it is and I'm happy to salvage it on the way to the landfill.
>>
>> src/compiler/scala/tools/nsc/models/Models.scala
>> src/compiler/scala/tools/nsc/models/SemanticTokens.scala
>> src/compiler/scala/tools/nsc/models/Signatures.scala
>> src/compiler/scala/tools/nsc/symtab/SymbolWalker.scala