Re: regressometer is wriggling

Paul Phillips wrote:
> I checked r22303 into trunk, it should be easy to cherry-pick from there
> into 2.8.x as is.
>

It's been ported to 2.8.x as r22309. Thanks for these patches, Paul.
Toni

I've committed a fix for #3563 to trunk.
Basically, it overrides `toSeq` in `Iterable` to return a list instead
of the stream, and slightly changes the documentation for `toSeq`. I
don't think we should require `toSeq` to be lazy as part of the
contract, as was added to the doc recently, but rather just implement it
to call `toStream` so that the Iterators work as expected.

Paul, do you mind taking a look? I've sent a review request.
Then I'll merge it into 2.8 branch.

Alex

On 16/06/10 11:05, Antonio Cunei wrote:
> Paul Phillips wrote:
>
>> I checked r22303 into trunk, it should be easy to cherry-pick from there
>> into 2.8.x as is.
>>
>>
> It's been ported to 2.8.x as r22309. Thanks for these patches, Paul.
> Toni
>
>

On Wed, Jun 16, 2010 at 06:40:30PM +0200, Aleksandar Prokopec wrote:
> Basically, it overrides `toSeq` in `Iterable` to return a list instead
> of the stream, and slightly changes the documentation for `toSeq`. I
> don't think we should require `toSeq` to be lazy as part of the
> contract, as was added to the doc recently, but rather just implement
> it to call `toStream` so that the Iterators work as expected.

Having TraversableOnce assume Stream and IterableLike assume List seems
like the right thing to me. +1.

Ok, thanks!

On 06/16/2010 07:49 PM, Paul Phillips wrote:
> On Wed, Jun 16, 2010 at 06:40:30PM +0200, Aleksandar Prokopec wrote:
>
>> Basically, it overrides `toSeq` in `Iterable` to return a list instead
>> of the stream, and slightly changes the documentation for `toSeq`. I
>> don't think we should require `toSeq` to be lazy as part of the
>> contract, as was added to the doc recently, but rather just implement
>> it to call `toStream` so that the Iterators work as expected.
>>
> Having TraversableOnce assume Stream and IterableLike assume List seems
> like the right thing to me. +1.
>
>