- About Scala
- Documentation
- Code Examples
- Software
- Scala Developers
Should PrettyPrinter indent/newline Text nodes?
Tue, 2009-02-10, 18:59
I've been using the PrettyPrinter to output XML, so that it's readable, but in the process my text content also gets newlined and indented. Should this behaviour of PrettyPrinter be changed?
PrettyPrinter.scala:
....
protected def traverse(node: Node, pscope: NamespaceBinding, ind: Int): Unit = node match {
case Text(s) if s.trim() == "" =>
;
case _:Atom[_] | _:Comment | _:EntityRef | _:ProcInstr =>
makeBox( ind, node.toString().trim() )
case g @ Group(xs) =>
traverse(xs.elements, pscope, ind)
case _ =>
.....
There's only one test for empty Text nodes. A simple alteration might just be a pattern for appending unformated Text node?
Tue, 2009-02-10, 21:17
#2
Re: Should PrettyPrinter indent/newline Text nodes?
In this course we could also modify pretty printing of empty tags from
to . What do you think?
On Feb 10, 2009, at 7:53 PM, Alex Cruise wrote:
> Trond Olsen wrote:
>> I've been using the PrettyPrinter to output XML, so that it's
>> readable, but in the process my text content also gets newlined and
>> indented. Should this behaviour of PrettyPrinter be changed?
> Changing the default behaviour would be controversial, but I like
> the idea of adding a flag.
>
> Please file an enhancement. :)
Cheers,
--
Normen Müller
Tue, 2009-02-10, 21:27
#3
Re: Should PrettyPrinter indent/newline Text nodes?
Normen Müller wrote:
> In this course we could also modify pretty printing of empty tags from
> to . What do you think?
That would be good too, although it's less a prettyprinter issue and
more of a generic serializer issue.
Note, though, that canonicalizers will always turn into and
they're *supposed* to be equivalent, although recent traffic on the Lift
list shows that IE gets confused by empty elements where a self-closing
one was expected.
-0xe1a
Trond Olsen wrote:
> I've been using the PrettyPrinter to output XML, so that it's
> readable, but in the process my text content also gets newlined and
> indented. Should this behaviour of PrettyPrinter be changed?
Changing the default behaviour would be controversial, but I like the
idea of adding a flag.
Please file an enhancement. :)
-0xe1a