FindBugs?

On 3/22/11 6:31 AM, Nils Kilden-Pedersen wrote:
> Has anyone on the compiler team looked into the warnings generated by
> FindBugs?

Yes.

> I'm not sure if they are false positives are if they in some
> cases are indicative of real issues.

Usually the first, sometimes the second.

% git log --oneline --grep=findbugs

7ca27a4 Some minor fixes found by findbugs. No review.
ff38baa A variety of bugfixes discovered by findbugs. Most of them are
examples of equality comparisons which are guaranteed to return false
because someone is not comparing what they think they're comparing.
df77673 More work and documentation for GenericRanges, plus minor
findbugs noticed issues.
daec561 A couple findbugs inspired bugfixes, and a new trait
scala.util.Hashable, now used by GenericRange.
c1a63e0 Two minor findbugs-discovered logic errors I've had in storage
until I had xml write access.
4f1f1ee A few more very minor fixes based on input from findbugs.
623808c Alters four meaningless equality comparison discovered by
findbugs; alters because some may still have room for improvement, but
all should be closer to correct than "certainly not." Closes bug #1444.
86e5034 rewrote an infinite loop spotted by findbugs to be more finite

On 3/22/11 6:31 AM, Nils Kilden-Pedersen wrote:

Has anyone on the compiler team looked into the warnings generated by
FindBugs?

Yes.

I'm not sure if they are false positives are if they in some
cases are indicative of real issues.

Usually the first, sometimes the second.

% git log --oneline  --grep=findbugs

7ca27a4 Some minor fixes found by findbugs.  No review.
ff38baa A variety of bugfixes discovered by findbugs.  Most of them are examples of equality comparisons which are guaranteed to return false because someone is not comparing what they think they're comparing.
df77673 More work and documentation for GenericRanges, plus minor findbugs noticed issues.
daec561 A couple findbugs inspired bugfixes, and a new trait scala.util.Hashable, now used by GenericRange.
c1a63e0 Two minor findbugs-discovered logic errors I've had in storage until I had xml write access.
4f1f1ee A few more very minor fixes based on input from findbugs.
623808c Alters four meaningless equality comparison discovered by findbugs; alters because some may still have room for improvement, but all should be closer to correct than "certainly not." Closes bug #1444.
86e5034 rewrote an infinite loop spotted by findbugs to be more finite

What about redundant null checks? FindBugs complains about that fairly
often. It's not in the source code, only in scalac's output.

On Mar 22, 11:46 am, Nils Kilden-Pedersen wrote:
> On Tue, Mar 22, 2011 at 10:25 AM, Paul Phillips wrote:
> > On 3/22/11 6:31 AM, Nils Kilden-Pedersen wrote:
>
> >> Has anyone on the compiler team looked into the warnings generated by
> >> FindBugs?
>
> > Yes.
>
> >  I'm not sure if they are false positives are if they in some
> >> cases are indicative of real issues.
>
> > Usually the first, sometimes the second.
>
> > % git log --oneline  --grep=findbugs
>
> > 7ca27a4 Some minor fixes found by findbugs.  No review.
> > ff38baa A variety of bugfixes discovered by findbugs.  Most of them are
> > examples of equality comparisons which are guaranteed to return false
> > because someone is not comparing what they think they're comparing.
> > df77673 More work and documentation for GenericRanges, plus minor findbugs
> > noticed issues.
> > daec561 A couple findbugs inspired bugfixes, and a new trait
> > scala.util.Hashable, now used by GenericRange.
> > c1a63e0 Two minor findbugs-discovered logic errors I've had in storage
> > until I had xml write access.
> > 4f1f1ee A few more very minor fixes based on input from findbugs.
> > 623808c Alters four meaningless equality comparison discovered by findbugs;
> > alters because some may still have room for improvement, but all should be
> > closer to correct than "certainly not." Closes bug #1444.
> > 86e5034 rewrote an infinite loop spotted by findbugs to be more finite
>
> Sweet.